ngsg commented on code in PR #5983:
URL: https://github.com/apache/hive/pull/5983#discussion_r2212479078
##########
shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java:
##########
@@ -148,13 +150,32 @@ public boolean next(K key, V value) throws IOException {
@Override
public K createKey() {
- K newKey = curReader.createKey();
- return (K)(new CombineHiveKey(newKey));
+ skipCorruptfile = jc.getBoolean("hive.exec.skip.protobuf.corruptfile",
false);
+ K newKey = null;
+ if (skipCorruptfile) {
+ try {
+ newKey = curReader.createKey();
+ } catch (NullPointerException e) {
Review Comment:
I'm not sure about handling `NullPointerException` at this point. Can we say
with certainty that a `NullPointerException` always results from a corrupted
file? If not, I don't think we could swallow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
