jiihye commented on code in PR #5793:
URL: https://github.com/apache/hive/pull/5793#discussion_r2214735626


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -1984,14 +1984,28 @@ private StringBuilder 
appendSimpleCondition(StringBuilder builder,
 
   private StringBuilder appendCondition(StringBuilder builder,
       String fieldName, String[] elements, boolean pattern, List<String> 
parameters) {
+    return appendCondition(builder, fieldName, elements, pattern, parameters, 
false);
+  }
+
+  private StringBuilder appendPatternConditionCaseSensitive(StringBuilder 
builder,
+      String fieldName, String elements, List<String> parameters) {
+    elements = normalizeIdentifier(elements);
+    return appendCondition(builder, fieldName, elements.split("\\|"), true, 
parameters, true);

Review Comment:
   @deniskuzZ 
   I've rebased this PR on top of the latest `master` to incorporate recent 
changes.
   ```
   commit 36abb824b04cb0ebb93e17efa145f9c3e6d3e255 (HEAD -> HIVE-28899, 
origin/HIVE-28899)
   Author: ji.hye.seo <sispi...@gmail.com>
   Date:   Mon Jun 16 13:57:32 2025 +0900
   
       Retain appendPatternCondition and remove caseSensitive flag
   
   commit 62e26120fa793e0c06fb945774a65199613ab86e
   Author: ji.hye.seo <sispi...@gmail.com>
   Date:   Fri May 2 13:54:34 2025 +0900
   
       remove appendPatternConditionCaseSensitive and rename 
appendPatternCondition to appendIdentifierPatternCondition
   
   commit 84626a3a64fc7a92c70baafa2c0608442b5b7dd4
   Author: ji.hye.seo <ji.hye....@navercorp.com>
   Date:   Mon Apr 28 10:53:33 2025 +0900
   
       HIVE-28899: Make 'get_table_meta' query case-sensitive to use index
   
   commit 5512ffda602bef605ad144f9040676149cc2c960 (upstream/master)
   Author: Stamatis Zampetakis <zabe...@gmail.com>
   Date:   Wed Jul 16 09:35:59 2025 +0300
   
       HIVE-29032: Enhance qt:database option to expose connection properties 
in qfiles (#5919)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to