vikramahuja1001 commented on code in PR #5976:
URL: https://github.com/apache/hive/pull/5976#discussion_r2218178318


##########
ql/src/test/results/clientpositive/llap/msck_repair_9.q.out:
##########
@@ -90,7 +90,7 @@ PREHOOK: Output: default@tbl_y
 POSTHOOK: query: MSCK REPAIR TABLE tbl_y
 POSTHOOK: type: MSCK
 POSTHOOK: Output: default@tbl_y
-Partitions not in metastore:   tbl_y:month=12/day=2    tbl_y:month=12/day=3    
tbl_y:month=12/day=__HIVE_DEFAULT_PARTITION__   
tbl_y:month=ANOTHER_PARTITION/day=3
+Partitions not in metastore:   tbl_y:month=12/day=2    tbl_y:month=12/day=3    
tbl_y:month=ANOTHER_PARTITION/day=3

Review Comment:
   Okay, so this test was buggy to begin with. Since default partition name is 
already changed to ANOTHER_PARTITION and since these are int partition columns, 
the only partition other than int type MSCK repair should add is the default 
partition value which in this case is ANOTHER_PARTITION. 
   So partition value __HIVE_DEFAULT_PARTITION__ shouldn't be added in this 
case.
   
   This bug is actually induced in HIVE-28654.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to