deniskuzZ commented on code in PR #5928:
URL: https://github.com/apache/hive/pull/5928#discussion_r2218320945
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/schematool/TestSchemaToolForMetastore.java:
##########
@@ -75,20 +69,13 @@ public class TestSchemaToolForMetastore {
private PrintStream outStream;
private SchemaToolTaskValidate validator;
- public TestSchemaToolForMetastore(DatabaseRule dbms){
- this.dbms = dbms;
+ public TestSchemaToolForMetastore(String dbType){
+ this.dbms = MetastoreRuleFactory.create(dbType);
}
@Parameterized.Parameters(name = "{0}")
- public static Collection<Object[]> databases() {
- List<Object[]> dbs = new ArrayList<>();
- dbs.add(new Object[] { new Derby(true) });
- dbs.add(new Object[] { new Mysql() });
- dbs.add(new Object[] { new Oracle() });
- dbs.add(new Object[] { new Postgres() });
- dbs.add(new Object[] { new Mariadb() });
- dbs.add(new Object[] { new Mssql() });
- return dbs;
+ public static Collection<String> databases() {
+ return Arrays.asList("derby.clean", "mysql", "oracle", "postgres",
"mariadb", "mssql");
Review Comment:
why not simply "derby"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
