KiranVelumuri commented on code in PR #5641:
URL: https://github.com/apache/hive/pull/5641#discussion_r2221315838


##########
standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.1.0.mysql.sql:
##########
@@ -1134,6 +1143,7 @@ CREATE TABLE MIN_HISTORY_WRITE_ID (
   MH_DATABASE varchar(128) NOT NULL,
   MH_TABLE varchar(256) NOT NULL,
   MH_WRITEID bigint NOT NULL,
+  CONSTRAINT MIN_HISTORY_WRITE_ID_PK PRIMARY KEY (MH_TXNID, MH_DATABASE, 
MH_TABLE, MH_WRITEID),

Review Comment:
   @saihemanth-cloudera Yes, we could have invisible columns for all the 
missing primary key tables only for MySQL, since not all schemas support 
invisible columns. Should this approach be okay?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to