ramitg254 commented on code in PR #5988:
URL: https://github.com/apache/hive/pull/5988#discussion_r2224258055
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -1096,13 +1095,6 @@ public static enum ConfVars {
@Deprecated
METASTORE_SERVER_MAX_THREADS("hive.metastore.server.max.threads", 1000,
"Maximum number of worker threads in the Thrift server's pool."),
- /**
- * @deprecated Use MetastoreConf.TCP_KEEP_ALIVE
- */
- @Deprecated
- METASTORE_TCP_KEEP_ALIVE("hive.metastore.server.tcp.keepalive", true,
- "Whether to enable TCP keepalive for the metastore server. Keepalive
will prevent accumulation of half-open connections."),
-
Review Comment:
@dengzhhu653 Sure,
but this property is not present in conf/hive-default.xml.template but
similar one `hive.server.tcp.keepalive` was there related to
```
SERVER_TCP_KEEP_ALIVE("hive.server.tcp.keepalive", true,
"Whether to enable TCP keepalive for the Hive Server. Keepalive will
prevent accumulation of half-open connections."),
```
which is different from this property so i didn't drop.
So should I drop this property as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
