saihemanth-cloudera commented on code in PR #5991:
URL: https://github.com/apache/hive/pull/5991#discussion_r2229637002
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1257,6 +1257,10 @@ public enum ConfVars {
// Partition management task params
+ PARTITION_MANAGEMENT_ENABLE("metastore.partition.management.enable",
"hive.metastore.partition.management.enable",
Review Comment:
If we set it 0 or -1 then we didn't handle else condition properly here:
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/HouseKeepingTasks.java#L116-L118
`long freq = task.runFrequency(TimeUnit.MILLISECONDS);
runningTasks.add(task);
metastoreTaskThreadPool.getPool().scheduleAtFixedRate(task, freq, freq,
TimeUnit.MILLISECONDS);`
and scheduleAtFixedRate() would throw illegalArgumentException.
Also, I thought a separate config would make it clear for end-users. If
you think there are too many configs and we should only work with
`metastore.partition.management.task.frequency`, please let me know. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
