ngsg commented on code in PR #5955:
URL: https://github.com/apache/hive/pull/5955#discussion_r2230231398
##########
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -61,19 +61,24 @@ public HiveMetaStoreClient(Configuration conf,
HiveMetaHookLoader hookLoader) th
public HiveMetaStoreClient(Configuration conf, HiveMetaHookLoader
hookLoader, Boolean allowEmbedded)
throws MetaException {
- this(conf, hookLoader, new ThriftHiveMetaStoreClient(conf, allowEmbedded));
+ this(conf, hookLoader, HiveMetaStoreClientBuilder.createClient(conf,
allowEmbedded));
}
private HiveMetaStoreClient(Configuration conf, HiveMetaHookLoader
hookLoader,
- ThriftHiveMetaStoreClient thriftClient) {
- super(createUnderlyingClient(conf, hookLoader, thriftClient), conf);
- this.thriftClient = thriftClient;
+ IMetaStoreClient baseMetaStoreClient) {
+ super(createUnderlyingClient(conf, hookLoader, baseMetaStoreClient), conf);
+
+ if (baseMetaStoreClient instanceof ThriftHiveMetaStoreClient) {
Review Comment:
Fixed as suggested. I wasn't aware of that syntax before. Thank you for the
helpful suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
