deniskuzZ commented on code in PR #5973:
URL: https://github.com/apache/hive/pull/5973#discussion_r2230734468
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -13000,24 +12979,15 @@ void gatherUserSuppliedFunctions(ASTNode ast) throws
SemanticException {
}
}
- boolean genResolvedParseTree(ASTNode ast, PlannerContext plannerCtx) throws
SemanticException {
+ protected boolean genResolvedParseTree(ASTNode ast, PlannerContext
plannerCtx) throws SemanticException {
ASTNode child = ast;
this.ast = ast;
viewsExpanded = new ArrayList<String>();
// 1. analyze and process the position alias
// step processPositionAlias out of genResolvedParseTree
- // 2. analyze create table command
- if (ast.getToken().getType() == HiveParser.TOK_CREATETABLE) {
- // if it is not CTAS, we don't need to go further and just return
- if ((child = analyzeCreateTable(ast, qb, plannerCtx)) == null) {
- return false;
- }
- } else {
- // TODO: reiterate on this in HIVE-28750
- queryState.setCommandType(HiveOperation.QUERY);
- }
+ queryState.setCommandType(HiveOperation.QUERY);
Review Comment:
please update the numbering (step 2 is gone)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
