deniskuzZ commented on code in PR #5961:
URL: https://github.com/apache/hive/pull/5961#discussion_r2236523952


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1641,6 +1645,12 @@ static void overlayTableProperties(Configuration 
configuration, TableDesc tableD
 
       // serialize table object into config
       Table serializableTable = SerializableTable.copyOf(table);
+      // set table format-version and write-mode information from tableDesc
+      List<String> writeConfigList = ImmutableList.of(
+          FORMAT_VERSION, DELETE_MODE, UPDATE_MODE, MERGE_MODE);
+      if (IcebergTableUtil.isV2Table(props::getProperty)) {

Review Comment:
   props is of Properties type, not Map



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to