okumin commented on code in PR #5882:
URL: https://github.com/apache/hive/pull/5882#discussion_r2255904055
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -33,21 +33,23 @@
/**
* Catalog & servlet factory.
+ * <p>This class is derivable on purpose; the factory class name is a
configuration property, this class
+ * can serve as a base for specialization.</p>
*/
public class HMSCatalogFactory {
- private static final String SERVLET_ID_KEY =
"metastore.in.test.iceberg.catalog.servlet.id";
+ private static final String SERVLET_ID_KEY =
"metastore.in.test.iceberg.catalog.servlet.id";
Review Comment:
```suggestion
private static final String SERVLET_ID_KEY =
"metastore.in.test.iceberg.catalog.servlet.id";
```
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -33,21 +33,23 @@
/**
* Catalog & servlet factory.
+ * <p>This class is derivable on purpose; the factory class name is a
configuration property, this class
+ * can serve as a base for specialization.</p>
Review Comment:
What extends this class? If nothing does it, I'd like you to revert the
visibility of methods and variables from `protected` to `private`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
