difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2258331758


##########
iceberg/iceberg-catalog/pom.xml:
##########
@@ -69,7 +69,6 @@
     <dependency>
       <groupId>org.apache.hive</groupId>
       <artifactId>hive-exec</artifactId>
-      <scope>test</scope>

Review Comment:
   Zoltan kept this dependency because `HMSTablePropertyHelper` depends on this 
two:
   ```
   import org.apache.hadoop.hive.ql.parse.TransformSpec;
   import org.apache.hadoop.hive.ql.session.SessionStateUtil;
   ```
   
   Also, `hive-exec` doesn't depend on any iceberg modules and other iceberg 
modules (iceberg-handler) depends on `hive-exec`, are you sure we can't have it?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to