deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2259574224
##########
iceberg/iceberg-catalog/pom.xml:
##########
@@ -69,7 +69,6 @@
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-exec</artifactId>
- <scope>test</scope>
Review Comment:
I am positive. Iceberg catalog shouldn't have any dependencies on runtime.
Please refactor or relocate the necessary functionality, but remove the
dependency.
Btw, we load iceberg classes in hive-exec via reflection and I think that is
a bad design.
##########
iceberg/iceberg-catalog/pom.xml:
##########
@@ -69,7 +69,6 @@
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-exec</artifactId>
- <scope>test</scope>
Review Comment:
I am positive. Iceberg catalog shouldn't have any dependencies on runtime.
Please refactor or relocate the necessary functionality, but remove the
dependency.
Btw, we load iceberg classes in hive-exec via reflection and I think that is
a bad design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
