kasakrisz commented on code in PR #6009:
URL: https://github.com/apache/hive/pull/6009#discussion_r2260492269


##########
ql/src/java/org/apache/hadoop/hive/ql/plan/VectorPTFDesc.java:
##########
@@ -321,6 +323,7 @@ public static VectorPTFEvaluatorBase 
getEvaluator(SupportedFunctionType function
       default:
         throw new RuntimeException("Unexpected column vector type " + 
columnVectorType + " for " + functionType);
       }
+      evaluator.setRespectNulls(respectNulls);

Review Comment:
   Could you please move this call to the end of the method before returning 
the `evaluator` instance? In that case this would be called only once int the 
entire method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to