Paramvir109 commented on code in PR #5845:
URL: https://github.com/apache/hive/pull/5845#discussion_r2264644687
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -83,6 +88,10 @@ public VectorMapJoinFastHashTableLoader() {
}
+ ExecutorService getLoadExecService() {
Review Comment:
service is shutdown
[here](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java#L338)
in the `load()` but since I can't test the load() method (As the original OOM
scenario is reproducible only with specific data under some low memory
conditions) via unit test therefore I need this package private getter to
actually close the service in my unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
