deniskuzZ commented on code in PR #5223:
URL: https://github.com/apache/hive/pull/5223#discussion_r2264913083
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java:
##########
@@ -1559,36 +1562,47 @@ public boolean dropPartition(String catName, String
dbName, String tableName, St
}
@Override
- public List<Partition> dropPartitions(String catName, String dbName, String
tblName,
- List<Pair<Integer, byte[]>> partExprs, PartitionDropOptions options,
EnvironmentContext context)
+ public List<Partition> dropPartitions(TableName tableName,
Review Comment:
what happens if someone invokes the legacy signature? it's gonna call the
delegate drectly?
````
public boolean dropPartition(String catName, String db_name, String
tbl_name, List<String> part_vals,
PartitionDropOptions options) throws NoSuchObjectException,
MetaException, TException {
return delegate.dropPartition(catName, db_name, tbl_name, part_vals,
options);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
