deniskuzZ commented on code in PR #5724:
URL: https://github.com/apache/hive/pull/5724#discussion_r2273087356
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -601,20 +601,27 @@ private boolean writeColStats(List<ColumnStatistics>
colStats, Table tbl) {
long snapshotId = tbl.currentSnapshot().snapshotId();
long snapshotSequenceNumber = tbl.currentSnapshot().sequenceNumber();
- colStats.forEach(statsObj -> {
- byte[] serializeColStats = SerializationUtils.serialize(statsObj);
- puffinWriter.add(
- new Blob(
- ColumnStatisticsObj.class.getSimpleName(),
- ImmutableList.of(1),
- snapshotId,
- snapshotSequenceNumber,
- ByteBuffer.wrap(serializeColStats),
- PuffinCompressionCodec.NONE,
- ImmutableMap.of("partition",
- String.valueOf(statsObj.getStatsDesc().getPartName()))
- ));
+ colStats.forEach(stats -> {
+ boolean isTblLevel = stats.getStatsDesc().isIsTblLevel();
+
+ for (Serializable statsObj : isTblLevel ? stats.getStatsObj() :
Collections.singletonList(stats)) {
+ byte[] serializeColStats = SerializationUtils.serialize(statsObj);
+ puffinWriter.add(
+ new Blob(
+ ColumnStatisticsObj.class.getSimpleName(),
+ ImmutableList.of(isTblLevel ? tbl.spec().schema().findField(
+ ((ColumnStatisticsObj) statsObj).getColName()).fieldId() :
1),
+ snapshotId,
+ snapshotSequenceNumber,
+ ByteBuffer.wrap(serializeColStats),
+ PuffinCompressionCodec.NONE,
Review Comment:
if I recall we had an issue with that in a past, but maybe we should revisit
this. Btw, in iceberg:
````
PuffinCompressionCodec defaultBlobCompression = PuffinCompressionCodec.NONE;
````
Impala uses config for that:
https://github.com/apache/impala/blob/7477107ca370ef4b0709855522f8d955e47edbec/java/puffin-data-generator/src/main/java/org/apache/impala/puffindatagenerator/PuffinDataGenerator.java#L566-L569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
