difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2322505459
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##########
@@ -280,9 +279,9 @@ private static void assertFileFormat(String format) {
}
protected void
setCommonHmsTablePropertiesForIceberg(org.apache.hadoop.hive.metastore.api.Table
hmsTable) {
- // If the table is not managed by Hive or REST catalog, then the location
should be set
- if (!Catalogs.hiveCatalog(conf, catalogProperties) &&
-
!CatalogUtil.ICEBERG_CATALOG_TYPE_REST.equals(CatalogUtils.getCatalogType(conf,
catalogProperties))) {
+ String catalogName =
catalogProperties.getProperty(InputFormatConfig.CATALOG_NAME);
+ if (Catalogs.ICEBERG_HADOOP_TABLE_NAME.equals(catalogName) ||
Catalogs.hadoopCatalog(conf, catalogProperties) ||
+ CatalogUtils.isCustomHadoopCatalogImpl(conf, catalogName)) {
Review Comment:
Done. Also had to move `Catalogs.hadoopCatalog()` to `CatalogUtils` because
it is called from `CatalogUtils.isHadoopTable()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
