deniskuzZ commented on code in PR #5724:
URL: https://github.com/apache/hive/pull/5724#discussion_r2322584392
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -637,7 +644,7 @@ private boolean writeColStats(List<ColumnStatistics>
colStats, Table tbl) {
return true;
} catch (Exception e) {
- LOG.warn("Unable to invalidate or merge stats: {}", e.getMessage());
+ LOG.warn("Unable to invalidate or merge column stats: {}",
e.getMessage());
Review Comment:
we can add that, but on a read path we have safe-gard: if we can't process
the stats file - return empty stats obj
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1864,19 +1861,6 @@ public void addResourcesForCreateTable(Map<String,
String> tblProps, HiveConf hi
}
}
- /**
- * Check the operation type of all snapshots which are newer than the
specified. The specified snapshot is excluded.
- * @param hmsTable table metadata stored in Hive Metastore
- * @param since the snapshot preceding the oldest snapshot which should be
checked.
- * The value null means all should be checked.
- * @return null if table is empty, true if all snapshots are {@link
SnapshotContext.WriteOperationType#APPEND}s,
- * false otherwise.
- *
- * @deprecated
- * <br>Use {@link HiveStorageHandler#getSnapshotContexts(
- * org.apache.hadoop.hive.ql.metadata.Table hmsTable, SnapshotContext since)}
- * and check {@link SnapshotContext.WriteOperationType#APPEND}.equals({@link
SnapshotContext#getOperation()}).
- */
Review Comment:
it's in interface
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1864,19 +1861,6 @@ public void addResourcesForCreateTable(Map<String,
String> tblProps, HiveConf hi
}
}
- /**
- * Check the operation type of all snapshots which are newer than the
specified. The specified snapshot is excluded.
- * @param hmsTable table metadata stored in Hive Metastore
- * @param since the snapshot preceding the oldest snapshot which should be
checked.
- * The value null means all should be checked.
- * @return null if table is empty, true if all snapshots are {@link
SnapshotContext.WriteOperationType#APPEND}s,
- * false otherwise.
- *
- * @deprecated
- * <br>Use {@link HiveStorageHandler#getSnapshotContexts(
- * org.apache.hadoop.hive.ql.metadata.Table hmsTable, SnapshotContext since)}
- * and check {@link SnapshotContext.WriteOperationType#APPEND}.equals({@link
SnapshotContext#getOperation()}).
- */
Review Comment:
it's present in interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
