deniskuzZ commented on code in PR #6074:
URL: https://github.com/apache/hive/pull/6074#discussion_r2355702653
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
@@ -60,18 +61,20 @@ public static List<FieldSchema> convert(Schema schema) {
* @return An equivalent Iceberg Schema
*/
public static Schema convert(List<FieldSchema> fieldSchemas) {
- return convert(fieldSchemas, false);
+ return convert(fieldSchemas, false, Collections.emptyMap());
}
/**
* Converts a Hive schema (list of FieldSchema objects) to an Iceberg schema.
- * @param fieldSchemas The list of the columns
- * @param autoConvert If <code>true</code> then TINYINT and SMALLINT is
converted to INTEGER and VARCHAR and CHAR is
- * converted to STRING. Otherwise if these types are used
in the Hive schema then exception is
- * thrown.
+ *
+ * @param fieldSchemas The list of the columns
+ * @param autoConvert If <code>true</code> then TINYINT and SMALLINT is
converted to INTEGER and VARCHAR and CHAR is
+ * converted to STRING. Otherwise if these types are
used in the Hive schema then exception is
+ * thrown.
+ * @param defaultValues Default values for columns, if any. The map is from
column name to default value.
* @return An equivalent Iceberg Schema
*/
- public static Schema convert(List<FieldSchema> fieldSchemas, boolean
autoConvert) {
+ public static Schema convert(List<FieldSchema> fieldSchemas, boolean
autoConvert, Map<String, String> defaultValues) {
Review Comment:
autoConvert should be last arg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
