abstractdog commented on PR #6051: URL: https://github.com/apache/hive/pull/6051#issuecomment-3305591278
> I'm not sure about how that restricted list works but I wonder: what happens when we want to disable the service that is already enabled? I'm thinking about the test, `query_history.q`. > > The reason why I'm asking is that comment from the test: > > ``` > -- any operation on query_history table might involve further record changes on query_history table, > -- so let's disable the feature while to reduce noise while checking the contents > set hive.query.history.enabled=false; > ``` > > I also wonder, what's about challenging the solution: is it possible to do the opposite direction and create an instance when the user wants to enable the service? qtests run on a different codepath, where the commands are directly interpreted through the Driver, so the same session-related check is bypassed I think regarding the opposite direction: on a real cluster, the user cannot enable the service after this patch on service level, which is the desired way, as the service needs to start and initialize together with the HS2 properly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
