thomasrebele commented on PR #6075: URL: https://github.com/apache/hive/pull/6075#issuecomment-3306752720
I had a look at this flaky test, too. If you look at the expected [query result](https://github.com/apache/hive/blob/96d1635f98d0cfd5b0cd01115bb738e1c6053b94/iceberg/iceberg-handler/src/test/results/positive/query_iceberg_metadata_of_unpartitioned_table.q.out#L104), the first columns are the same, but the first different column is not sorted lexicographically: ``` 0 hdfs://### HDFS PATH ### ORC 0 #Masked# 378 ... 0 hdfs://### HDFS PATH ### ORC 0 #Masked# 365 ... 0 hdfs://### HDFS PATH ### ORC 0 #Masked# 374 ... ``` The problem is that it is sorted on the original value of `### HDFS PATH ###`, and after sorting the value is replaced. Changing the query to make this deterministic is a workaround for this particular q file. A proposal for a more general fix: refactor the [masking](https://github.com/apache/hive/blob/96d1635f98d0cfd5b0cd01115bb738e1c6053b94/itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java#L972) so that it is done before the [sorting](https://github.com/apache/hive/blob/96d1635f98d0cfd5b0cd01115bb738e1c6053b94/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java#L286) (`out` is a `org.apache.hadoop.hive.common.io.SortPrintStream`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
