ayushtkn commented on code in PR #6074:
URL: https://github.com/apache/hive/pull/6074#discussion_r2358623497
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -5064,6 +5070,7 @@ private RowResolver getColForInsertStmtSpec(Map<String,
ExprNodeDesc> targetCol2
}
colListPos++;
}
+ SessionStateUtil.addResource(conf, MISSING_COLUMNS, missingColumns);
Review Comment:
I tried debugging my test and placed a breakpoint here—it hit once for the
insert query. Since this code is part of getColForInsertStmtSpec, it makes
sense that it should be invoked only once. There aren't multiple methods that
call into this, and the native missing column handling is also done here:
```
String f = targetTableColNames.get(i);
if (targetCol2Projection.containsKey(f)) {
// put existing column in new list to make sure it is in the right position
}
```
From what I observed during debugging, it should only be called once, since
it’s essentially capturing column projection. If it’s being triggered multiple
times, that would be surprise to me. There might be some specific case where it
does get called more than once, but I’m not fully sure about that yet. Not much
experience here :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
