kasakrisz commented on code in PR #6070:
URL: https://github.com/apache/hive/pull/6070#discussion_r2348293012
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java:
##########
@@ -334,19 +343,19 @@ public static UnparseTranslator
collectUnescapeIdentifierTranslations(ASTNode no
return unparseTranslator;
}
- static class ColumnExprProcessor implements SemanticNodeProcessor {
+ static class IdentifierProcessor implements SemanticNodeProcessor {
@Override
public Object process(Node nd, Stack<Node> stack, NodeProcessorCtx
procCtx, Object... nodeOutputs)
- throws SemanticException {
+ throws SemanticException {
UnparseTranslator unparseTranslator =
((QuotedIdExpressionContext)procCtx).getUnparseTranslator();
- ASTNode tokTableOrColNode = (ASTNode) nd;
- for (int i = 0; i < tokTableOrColNode.getChildCount(); ++i) {
- ASTNode child = (ASTNode) tokTableOrColNode.getChild(i);
- if (child.getType() == HiveParser.Identifier) {
- unparseTranslator.addIdentifierTranslation(child);
- }
+ ASTNode identifier = (ASTNode) nd;
+ String id = identifier.getText();
+ if (FunctionRegistry.getFunctionInfo(id) != null){
Review Comment:
Yes. Hive doesn't support special and whitespace characters in function
names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
