deniskuzZ commented on PR #6104: URL: https://github.com/apache/hive/pull/6104#issuecomment-3338123976
> The design of FetchConverter made it difficult to implement the idea of this PR cleanly. Alternatively, we could make FetchConverter an interface (and the old class would become FetchConverterImpl) to simplify the logic of LambdaFetchConverter. What do you think, @deniskuzZ? you can also declare FetchConverter as abstract and rename accordingly [Base/Abstract]FetchConverter. However, I think interface with some default might be better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
