jintongjiang commented on code in PR #6078:
URL: https://github.com/apache/hive/pull/6078#discussion_r2383332627
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizableEvent.java:
##########
@@ -40,6 +44,31 @@ protected HiveMetaStoreAuthorizableEvent(PreEventContext
preEventContext) {
this.preEventContext = preEventContext;
}
+ protected HiveAuthzContext buildAuthzContext(String commandString) {
+ HiveAuthzContext.Builder builder = new HiveAuthzContext.Builder();
+
+ if (commandString != null) {
+ builder.setCommandString(commandString);
+ }
+
+ // TODO: refer to SessionManager/HiveSessionImpl for details on getting
ipAddress and forwardedAddresses
+ builder.setForwardedAddresses(new ArrayList<>());
+
+ String ipAddress = HMSHandler.getIPAddress();
+ builder.setUserIpAddress(ipAddress);
+
+ Map<String, Object> clientConfig =
HiveMetaStoreAuthorizer.getClientConfig();
+ if (clientConfig != null) {
+ builder.setClientConfig(clientConfig);
+ }
+
+ return builder.build();
+ }
+
+ protected HiveAuthzContext buildAuthzContext() {
Review Comment:
Fix in the commit: 6c5d6b990a479a65fbba29f6879de959ba8fc6b9
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/events/ReadDatabaseEvent.java:
##########
@@ -40,10 +41,14 @@ public ReadDatabaseEvent(PreEventContext preEventContext) {
super(preEventContext);
}
- @Override public HiveMetaStoreAuthzInfo getAuthzContext() {
- HiveMetaStoreAuthzInfo ret =
- new HiveMetaStoreAuthzInfo(preEventContext,
HiveOperationType.SHOWDATABASES, getInputHObjs(), getOutputHObjs(),
- COMMAND_STR);
+ @Override
+ public HiveMetaStoreAuthzInfo getAuthzContext() {
+ List<HivePrivilegeObject> inputHObjs = getInputHObjs();
+ List<HivePrivilegeObject> outputHObjs = getOutputHObjs();
+ HiveAuthzContext authzContext = buildAuthzContext(COMMAND_STR);
+ HiveMetaStoreAuthzInfo ret = new HiveMetaStoreAuthzInfo(preEventContext,
HiveOperationType.SHOWDATABASES,
+ inputHObjs, outputHObjs, COMMAND_STR, authzContext);
Review Comment:
fix in the commit: 6c5d6b990a479a65fbba29f6879de959ba8fc6b9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
