dengzhhu653 commented on code in PR #6085:
URL: https://github.com/apache/hive/pull/6085#discussion_r2370879363
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/security/HadoopThriftAuthBridge.java:
##########
@@ -374,6 +380,12 @@ protected Server(String keytabFile, String principalConf,
String clientConf)
}
}
+ public Server(String keytabFile, String principalConf, String clientConf,
CallbackHandler callbackHandler)
+ throws TTransportException {
+ this(keytabFile, principalConf, clientConf);
+ this.callbackHandler = callbackHandler;
Review Comment:
nit: you can add a new method `setCallBackHandler` to init the callback
compare to a new constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
