stiga-huang commented on code in PR #6058:
URL: https://github.com/apache/hive/pull/6058#discussion_r2435064233


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/messaging/json/JSONReloadMessage.java:
##########
@@ -133,6 +138,11 @@ public Partition apply(@Nullable Object input) {
             });
     }
 
+    @Override
+    public Partition getPtnObj() throws Exception {

Review Comment:
   Impala is currently compiled with `getPtnObj()` so we have to add back this 
method for compatibility:
   
https://github.com/apache/impala/blob/ebbc67cf40bd856253d07c649028888d85c772cc/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java#L600
   
   When it returns null, the RELOAD event will be performed on the whole table:
   
https://github.com/apache/impala/blob/ebbc67cf40bd856253d07c649028888d85c772cc/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java#L3450-L3454
   I think this is fine since if the RELOAD event is on multiple partitions, 
reloading the whole table makes sure they are reloaded.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to