vikramahuja1001 commented on code in PR #6073:
URL: https://github.com/apache/hive/pull/6073#discussion_r2386674552
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -7261,6 +7266,10 @@ public static String generateDeprecationWarning() {
+ "versions. Please adjust DDL towards the new semantics.";
}
+ public static String generateRemovedWarning() {
+ return "This config does not exist in the current version of Hive.
Consider removing this config.";
+ }
+
Review Comment:
I checked the method `addDeprecation`. This particular method takes oldKeys
and newKeys(which are replacing the oldKeys) and it also has a null check to
make sure newKeys are not null. Now since we have removed the properties there
are no newKeys in our case making the method unusable for us.
Do let me know in case there is some other way to use the same functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
