abstractdog commented on PR #6081:
URL: https://github.com/apache/hive/pull/6081#issuecomment-3385102347
> in my opinion it's a bit of overkill. We shouldn't copy code from
kafka-handler, instead we might initialize suppliers lazily only when
UserGroupInformation.isSecurityEnabled cc @abstractdog
>
> ```
> private void getCredentialsFromSuppliers(BaseWork work, Set<TableDesc>
tables, DAG dag, JobConf conf) {
> if (!UserGroupInformation.isSecurityEnabled()){
> return;
> }
> ..
> lazyInitCredentialSuppliers();
> }
> ```
>
> Note, this is only a test classpath issue, in production deployment
kafka-handler jar would be always present.
the original goal was to completely remove kafka dependency from ql, which
is the case for every other third party that hive provides a storage handler
for, so we should maintain that behavior
I agree with trying the lazy approach if security is disabled as it would
easily solve the test log noise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
