soumyakanti3578 commented on code in PR #6067:
URL: https://github.com/apache/hive/pull/6067#discussion_r2396253892
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java:
##########
@@ -51,6 +52,11 @@ public HiveAggregate(RelOptCluster cluster, RelTraitSet
traitSet, RelNode child,
groupSet, groupSets, aggCalls);
}
+ public HiveAggregate(RelInput input) {
+ this(input.getCluster(), input.getTraitSet(), input.getInput(),
+ input.getBitSet("group"), input.getBitSetList("groups"),
input.getAggregateCalls("aggs"));
Review Comment:
Yes, we can call `super` directly in some of them. We cannot call `super`
for anything that extends `Join` as it doesn't have the constructor. There are
others where we need to do some post-processing after calling `super`. I will
do these changes in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
