deniskuzZ commented on code in PR #6142:
URL: https://github.com/apache/hive/pull/6142#discussion_r2453534698
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetastoreHousekeepingLeader.java:
##########
@@ -34,7 +35,7 @@ public class TestMetastoreHousekeepingLeader extends
MetastoreHousekeepingLeader
@Before
public void setUp() throws Exception {
- internalSetup("localhost", true);
+ internalSetup("localhost", MetastoreConf.newMetastoreConf());
Review Comment:
Interesting approach to instantiate and use a base test class within another
test.
https://github.com/apache/hive/pull/6142/files#diff-bd73307ca500a5ceb6b862f1819eb919a4f03f8db1737fad425a1b684353c713R46
It might be cleaner to extract the service logic into a separate class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
