deniskuzZ commented on code in PR #6160:
URL: https://github.com/apache/hive/pull/6160#discussion_r2477983839
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##########
@@ -1052,10 +1052,25 @@ public static Path toTaskTempPath(Path orig) {
}
public static Path toTempPath(Path orig) {
- if (orig.getName().indexOf(tmpPrefix) == 0) {
+ return toTempPath(orig, tmpPrefix);
+ }
+
+ public static Path toTempPath(Path orig, String prefix) {
+ if (orig.getName().indexOf(prefix) == 0) {
return orig;
}
- return new Path(orig.getParent(), tmpPrefix + orig.getName());
+ return new Path(orig.getParent(), prefix + orig.getName());
+ }
+
+ /**
+ * This method is to convert a path into a temporary path for the direct
insert manifest files.
+ * It is important to use a prefix which starts with '_', like '_tmp.', so
the content of this
+ * directory would be filtered out by the AcidUtils.acidHiddenFileFilter.
+ * @param orig
+ * @return
+ */
+ public static Path toTempPathForManifestDir(String orig) {
Review Comment:
maybe `toManifestDirTempPath` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
