Aggarwal-Raghav commented on code in PR #6170:
URL: https://github.com/apache/hive/pull/6170#discussion_r2500681572
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java:
##########
@@ -359,8 +359,11 @@ public List<Event> initialize() throws Exception {
splits[0] = new HiveInputFormat.HiveInputSplit(fileSplit, partIF);
}
} else {
- // Raw splits
- splits = inputFormat.getSplits(jobConf,
numSplits.orElse(Math.multiplyExact(availableSlots, (int)waves)));
+ // Raw splits.
+ splits =
+ inputFormat.getSplits(
+ jobConf,
+ numSplits.orElse((int) Math.min(availableSlots * waves,
Integer.MAX_VALUE)));
Review Comment:
yes it can be done and I'm also in favour of that. It just that,
`multiplyExact` protects from overflow hence kept it. will update it after CI
outcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
