okumin opened a new pull request, #6171:
URL: https://github.com/apache/hive/pull/6171
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Add a prefixed message, `Got exception:
org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAccessControlException`,
to MetaException when HiveMetaStoreAuthorizer handles
HiveAccessControlException, and make HiveCatalog translate it to Iceberg's
ForbiddenException.
This Pull Request implements the first option in the following document, and
I'm not obsessed with this option; I chose it first because the change is
minimal. I'm open to Option 2 or 3, or another suggestion.
https://docs.google.com/document/d/1SMvIud9k5lVSzqjgCzohHH59oW5MWAwA9BW-pPr9yIc/edit?usp=sharing
### Why are the changes needed?
Currently, when Ranger rejects an access, HiveMetastore throws
`MetaException(message:<Message thrown by Ranger>)`, and a Thrift client can't
get further information. So, HiveCatalog can't distinguish it from a generic
error, i.e., an internal server error. Iceberg-based data pipeline can't
process the error correctly(might retry it), and HMS Iceberg REST API can't
return the correct status code.
### Does this PR introduce _any_ user-facing change?
No. The error message will contain more information.
### How was this patch tested?
I added integration tests to verify that thrown exceptions are handled
correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
