ramitg254 commented on code in PR #6110:
URL: https://github.com/apache/hive/pull/6110#discussion_r2518955218
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/VectorizedKafkaRecordReader.java:
##########
@@ -150,7 +151,7 @@ private void cleanRowBoat() {
LOG.trace("total read bytes [{}]", readBytes);
if (consumer != null) {
consumer.wakeup();
- consumer.close();
+ consumer.close(Duration.ZERO);
Review Comment:
due to this commit https://github.com/apache/kafka/pull/12590 fetch session
is not closed before the timeout duration elapsed and default one is 30*1000
so it was causing issues KafkaRecordIteratorTest as fetch session was left
active from earlier consumer leading wrong offset reading for the next one. So
it is safer to use Duration.ZERO as timeout duration is now respected for
fetch session which was not the case earlier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
