InvisibleProgrammer commented on code in PR #6194:
URL: https://github.com/apache/hive/pull/6194#discussion_r2538135981
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/columnstats/merge/DecimalColumnStatsMergerTest.java:
##########
@@ -180,47 +189,59 @@ public void testMergeNonNullValues() {
@Test
public void testDecimalCompareEqual() {
- assertTrue(DECIMAL_3.equals(DECIMAL_3));
+ assertTrue(DECIMAL_3.equals(getDecimal("3", 3, 0)));
Review Comment:
That test is... interesting. So we are testing if we call `getDecimal` twice
with the same parameters, we get the same result.
As I see, it is the same for the original test case.
I don't know what is the value of such a test. Can we just drop the test
case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
