okumin commented on code in PR #6171:
URL: https://github.com/apache/hive/pull/6171#discussion_r2548879931
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveClientPool.java:
##########
@@ -92,6 +118,11 @@ protected boolean isConnectionException(Exception e) {
e.getMessage().contains("Got exception:
org.apache.thrift.transport.TTransportException");
}
+ private boolean isAccessControlException(MetaException exception) {
+ return exception.getMessage() != null && exception.getMessage().startsWith(
+ "Got exception:
org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAccessControlException");
Review Comment:
The current style is aligned with L118, `Got exception:
org.apache.thrift.transport.TTransportException`. To be honest, I don't have a
preference. They should eventually be consistent between apache/hive and
apache/iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
