zabetak commented on code in PR #6165:
URL: https://github.com/apache/hive/pull/6165#discussion_r2550031108
##########
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/TestMapJoinOperator.java:
##########
@@ -1343,6 +1349,93 @@ public void testString2() throws Exception {
} while (!hiveConfVariationsDone);
}
+ /**
+ * Test case for INNER vector map join with only small table key projection
- string type.
+ *
+ * @throws Exception Exception
+ */
+ @Test
+ public void testSmallTableKeyOnlyProjectionWithEmptyValueString() throws
Exception {
Review Comment:
Adding tests in this class are useful but it may not be the best option in
every situation. These tests depend on random generation of input/output and
they are good for covering general behavior of the joins operators but for edge
cases and very specific bugs having fixed input & output and join configuration
would be much easier to reason about.
For showcasing the bug in this PR (if there is one), it would really help to
have a dedicated test case possibly in another class and have well-defined and
minimal input/output and join settings. Then we can discuss if we also need
these randomized tests. The bug implies a problem in a binary join operator so
we should be able to demonstrate the issue by correctly picking the schema/data
for the left and right side of the join having a few rows on each side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
