difin commented on code in PR #6210:
URL: https://github.com/apache/hive/pull/6210#discussion_r2553392653


##########
standalone-metastore/pom.xml:
##########
@@ -665,6 +665,19 @@
             </execution>
           </executions>
         </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-compiler-plugin</artifactId>
+          <version>3.14.0</version>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-javadoc-plugin</artifactId>
+          <version>3.11.2</version>
+          <configuration>
+            <source>${maven.compiler.source}</source>
+          </configuration>
+        </plugin>

Review Comment:
   I think the same changes are needed in `storage-api`.
   Without these changes in `storage-api`, its javadoc is created in 
`target/site/apidocs`, and with these changes - in `target/reports/apidocs`, 
like the `standalone-metastore` jaavdoc.



##########
standalone-metastore/pom.xml:
##########
@@ -665,6 +665,19 @@
             </execution>
           </executions>
         </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-compiler-plugin</artifactId>
+          <version>3.14.0</version>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-javadoc-plugin</artifactId>
+          <version>3.11.2</version>
+          <configuration>
+            <source>${maven.compiler.source}</source>
+          </configuration>
+        </plugin>

Review Comment:
   I think the same changes are needed in `storage-api`.
   Without these changes in `storage-api`, its javadoc is created in 
`target/site/apidocs`, and with these changes - in `target/reports/apidocs`, 
like the `standalone-metastore` javadoc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to