wecharyu commented on code in PR #6205:
URL: https://github.com/apache/hive/pull/6205#discussion_r2560458122
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -6550,6 +6550,10 @@ public HiveConf(Configuration other, Class<?> cls) {
initialize(cls);
}
+ private HiveConf(Configuration other) {
Review Comment:
How about making it `public` and use it for a clone?
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -7297,6 +7301,7 @@ public Map<String, String> subtree(String string) {
return ret;
}
+
Review Comment:
nit: unnecessary empty line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
