zabetak commented on code in PR #6214:
URL: https://github.com/apache/hive/pull/6214#discussion_r2570796318
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:
##########
@@ -806,7 +806,7 @@ public final class FunctionRegistry {
(Class<? extends GenericUDF>)
Class.forName("org.apache.iceberg.mr.hive.udf.GenericUDFIcebergHour"));
system.registerGenericUDF("iceberg_zorder",
(Class<? extends GenericUDF>)
Class.forName("org.apache.iceberg.mr.hive.udf.GenericUDFIcebergZorder"));
- } catch (ClassNotFoundException e) {
+ } catch (ClassNotFoundException | NoClassDefFoundError e) {
Review Comment:
In general, we should not try to catch instances of `Error` in application
code. Moreover, the Javadoc of `NoClassDefFoundError` writes the following:
```java
* The searched-for class definition existed when the currently
* executing class was compiled, but the definition can no longer be
* found.
```
If we get this exception then it seems more like an IDE config issue rather
than something that we need to fix here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
