kokila-19 commented on code in PR #6152:
URL: https://github.com/apache/hive/pull/6152#discussion_r2599756495
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveFileWriterFactory.java:
##########
@@ -149,4 +160,30 @@ HiveFileWriterFactory build() {
positionDeleteRowSchema);
}
}
+
+ /**
+ * Check if the schema contains any variant columns.
+ */
+ private static boolean hasVariantColumns(Schema schema) {
+ return schema.columns().stream()
+ .anyMatch(field -> field.type() instanceof Types.VariantType);
+ }
+
+ /**
+ * Check if variant shredding is enabled via table properties.
+ */
+ private static boolean isVariantShreddingEnabled(Map<String, String>
properties) {
+ String shreddingEnabled = properties.get("variant.shredding.enabled");
Review Comment:
Would be better to use constant string for property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
