konstantinb commented on code in PR #6208:
URL: https://github.com/apache/hive/pull/6208#discussion_r2612532522
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java:
##########
@@ -249,7 +249,7 @@ private void getColumnDataForPartitionKeyColumn(Table
table, List<FieldSchema> c
ColStatistics.Range r = cs.getRange();
StatObjectConverter.fillColumnStatisticsData(partCol.getType(), data, r ==
null ? null : r.minValue,
r == null ? null : r.maxValue, r == null ? null : r.minValue, r ==
null ? null : r.maxValue,
- r == null ? null : r.minValue.toString(), r == null ? null :
r.maxValue.toString(),
+ r == null || r.minValue == null ? null : r.minValue.toString(), r ==
null || r.maxValue == null ? null : r.maxValue.toString(),
Review Comment:
the refactored fillColumnStatisticsData() with the prototype of
public static void fillColumnStatisticsData(ColStatistics cs, String colType,
ColumnStatisticsData data) throws MetaException {
cannot reside in StatObjectConverter because it belongs to the metastore
module while ColStatistics belongs to ql which depends on metastore. Therefore,
I've decied to add it to StatsUtils (open for suggestions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
