soumyakanti3578 commented on code in PR #6155:
URL: https://github.com/apache/hive/pull/6155#discussion_r2621838116
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java:
##########
@@ -235,6 +237,10 @@ private TezSessionState getSession(HiveConf conf, boolean
doOpen) throws Excepti
// able to handle not being initialized. Perhaps we should get rid
of the instance and
// move the setupPool code to ctor. For now, at least
hasInitialSessions will be false.
String queueName = conf.get(TezConfiguration.TEZ_QUEUE_NAME);
+ String tez_queues = HiveConf.getVar(conf,
ConfVars.HIVE_SERVER2_TEZ_DEFAULT_QUEUES);
Review Comment:
Please change the variable to `tezQueues`
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -4088,9 +4088,9 @@ public static enum ConfVars {
"If hive.server2.tez.initialize.default.sessions is enabled, the
maximum number of\n" +
"threads to use to initialize the default sessions."),
HIVE_SERVER2_TEZ_SESSION_RESTRICTED_CONFIGS("hive.server2.tez.sessions.restricted.configs",
"",
- "The configuration settings that cannot be set when submitting jobs to
HiveServer2. If\n" +
- "any of these are set to values different from those in the server
configuration, an\n" +
- "exception will be thrown."),
+ "The configuration settings that cannot be set when submitting jobs to
HiveServer2. If\n" +
+ "any of these are set to values different from those in the server
configuration, an\n" +
+ "exception will be thrown."),
Review Comment:
These changes seem unrelated to the issue, and may lead to merge conflict
later. Please consider reverting these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
