wecharyu commented on code in PR #5851:
URL: https://github.com/apache/hive/pull/5851#discussion_r2191480129
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -4780,7 +4776,22 @@ protected void
drop_table_with_environment_context(String catName, String dbname
dropTableReq.setCatalogName(catName);
dropTableReq.setDropPartitions(true);
dropTableReq.setEnvContext(envContext);
- client.drop_table_req(dropTableReq);
+ dropTableReq.setAsyncDrop(!isLocalMetaStore());
+ TableOpResp resp = client.drop_table_req(dropTableReq);
+ dropTableReq.setId(resp.getId());
+ try {
+ while (!resp.isFinished() && !Thread.currentThread().isInterrupted()) {
+ resp = client.drop_table_req(dropTableReq);
Review Comment:
Consider adding a small sleep interval to avoid frequent calls.
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -1781,7 +1781,16 @@ struct DropTableRequest {
3: required string tableName,
4: optional bool deleteData,
5: optional EnvironmentContext envContext,
- 6: optional bool dropPartitions
+ 6: optional bool dropPartitions,
+ 7: optional string id,
+ 8: optional bool asyncDrop,
+ 9: optional bool cancel
+}
+
+struct TableOpResp {
Review Comment:
How about `TableOperationResponse`?
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TableOperationsHandler.java:
##########
@@ -0,0 +1,380 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.util.concurrent.MoreExecutors;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.UUID;
+import java.util.concurrent.Callable;
+import java.util.concurrent.CancellationException;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.stream.Collectors;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hive.common.TableName;
+import org.apache.hadoop.hive.metastore.api.Database;
+import org.apache.hadoop.hive.metastore.api.DropTableRequest;
+import org.apache.hadoop.hive.metastore.api.GetTableRequest;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.NoSuchObjectException;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.hadoop.hive.metastore.api.TableOpResp;
+import org.apache.hadoop.hive.metastore.events.DropTableEvent;
+import org.apache.hadoop.hive.metastore.events.PreDropTableEvent;
+import org.apache.hadoop.hive.metastore.messaging.EventMessage;
+import org.apache.hadoop.hive.metastore.utils.MetaStoreUtils;
+import org.apache.hadoop.hive.metastore.utils.SecurityUtils;
+import org.apache.thrift.TBase;
+import org.apache.thrift.TException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.hadoop.hive.metastore.ExceptionHandler.handleException;
+import static
org.apache.hadoop.hive.metastore.HMSHandler.checkTableDataShouldBeDeleted;
+import static
org.apache.hadoop.hive.metastore.HMSHandler.isDbReplicationTarget;
+import static org.apache.hadoop.hive.metastore.HMSHandler.isMustPurge;
+import static
org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.getDefaultCatalog;
+import static
org.apache.hadoop.hive.metastore.utils.StringUtils.normalizeIdentifier;
+
+public class TableOperationsHandler<T extends TBase> {
+ private static final Logger LOG =
LoggerFactory.getLogger(TableOperationsHandler.class);
+ private static final Map<String, TableOperationsHandler<?>>
+ OPID_TO_HANDLER = new ConcurrentHashMap<>();
+ private static final ScheduledExecutorService OPID_CLEANER =
Executors.newScheduledThreadPool(1, r -> {
+ Thread thread = new Thread(r);
+ thread.setDaemon(true);
+ thread.setName("TableOperationsHandler-cleaner");
+ return thread;
+ });
+
+ private volatile StringBuffer state = new StringBuffer("Preparing context");
+ private String id;
+ private final IHMSHandler handler;
+ private final T request;
+ private final ExecutorService executor;
+ private final boolean async;
+ private Future<Void> future;
+ private Path tblPath;
+ private Table tbl;
+ private TableName tableName;
+ private volatile Object result;
+ private String logMsgPrefix;
+ private final AtomicBoolean aborted = new AtomicBoolean();
+
+ private TableOperationsHandler(String id) throws TException, IOException {
+ this(null, false, null);
+ this.id = id;
+ }
+
+ private TableOperationsHandler(IHMSHandler handler, boolean async, T request)
+ throws TException, IOException {
+ this.id = UUID.randomUUID().toString();
+ this.handler = handler;
+ this.request = request;
+ this.async = async;
+ OPID_TO_HANDLER.put(id, this);
+ if (async) {
+ this.executor = Executors.newFixedThreadPool(1, r -> {
+ Thread thread = new Thread(r);
+ thread.setDaemon(true);
+ thread.setName("TableOperationsHandler " + id);
+ return thread;
+ });
+ } else {
+ this.executor = MoreExecutors.newDirectExecutorService();
+ }
+ this.runTableOperation();
+ }
+
+ public void dropTable() throws TException {
+ DropTableRequest dropReq = (DropTableRequest) request;
+ DropTableResult dropResult = (DropTableResult) result;
+ boolean success = false;
+ List<Path> partPaths = null;
+ Map<String, String> transactionalListenerResponses =
Collections.emptyMap();
+ Database db = null;
+ boolean isReplicated = false;
+ RawStore ms = handler.getMS();
+ try {
+ ms.openTransaction();
+ String catName = tableName.getCat();
+ String dbname = tableName.getDb();
+ String name = tableName.getTable();
+ // HIVE-25282: Drop/Alter table in REMOTE db should fail
+ db = ms.getDatabase(catName, dbname);
+ if (MetaStoreUtils.isDatabaseRemote(db)) {
+ throw new MetaException("Drop table in REMOTE database " +
db.getName() + " is not allowed");
+ }
+ isReplicated = isDbReplicationTarget(db);
+
+ checkInterrupted();
+ // Check if table is part of a materialized view.
+ // If it is, it cannot be dropped.
+ List<String> isPartOfMV = ms.isPartOfMaterializedView(catName, dbname,
name);
+ if (!isPartOfMV.isEmpty()) {
+ throw new MetaException(String.format("Cannot drop table as it is used
in the following materialized" +
+ " views %s%n", isPartOfMV));
+ }
+
+ ((HMSHandler) handler).firePreEvent(new PreDropTableEvent(tbl,
dropReq.isDeleteData(), handler));
+
+ state = new StringBuffer();
+ // Drop the partitions and get a list of locations which need to be
deleted
+ if (dropReq.isDropPartitions()) {
+ checkInterrupted();
+ List<String> locations = ms.dropAllPartitionsAndGetLocations(tableName,
+ tblPath != null ? handler.getWh().getDnsPath(tblPath).toString() :
null, state);
+ partPaths =
locations.stream().map(Path::new).collect(Collectors.toList());
+ }
+ // Drop any constraints on the table
+ ms.dropConstraint(catName, dbname, name, null, true);
+
+ checkInterrupted();
+ state = new StringBuffer("Dropping table");
+ if (!ms.dropTable(catName, dbname, name)) {
+ throw new MetaException("Unable to drop table " + tableName);
+ } else {
+ state = new StringBuffer("Notifying transaction listeners");
+ if (!handler.getTransactionalListeners().isEmpty()) {
+ transactionalListenerResponses =
+
MetaStoreListenerNotifier.notifyEvent(handler.getTransactionalListeners(),
+ EventMessage.EventType.DROP_TABLE,
+ new DropTableEvent(tbl, true, dropReq.isDeleteData(),
handler, isReplicated),
+ dropReq.getEnvContext());
+ }
+ checkInterrupted();
+ success = ms.commitTransaction();
+ }
+ dropResult.fill(success, isMustPurge(dropReq.getEnvContext(), tbl),
+ ReplChangeManager.shouldEnableCm(db, tbl), partPaths);
+ } finally {
+ try {
+ if (!success) {
+ ms.rollbackTransaction();
+ }
+ if (!handler.getListeners().isEmpty()) {
+ MetaStoreListenerNotifier.notifyEvent(handler.getListeners(),
EventMessage.EventType.DROP_TABLE,
+ new DropTableEvent(tbl, success, dropReq.isDeleteData(),
handler, isReplicated), dropReq.getEnvContext(),
+ transactionalListenerResponses, ms);
+ }
+ } finally {
+ OPID_CLEANER.schedule(() -> OPID_TO_HANDLER.remove(id), 1,
TimeUnit.HOURS);
+ }
+ }
+ }
+
+ public TableOpResp toTableOpResp() throws TException {
+ if (future == null) {
+ throw new IllegalStateException(logMsgPrefix + " hasn't started yet");
+ }
+ try {
+ Object v = async ? future.get(100, TimeUnit.MILLISECONDS) : future.get();
+ } catch (TimeoutException e) {
+ // No Op, return to the caller since long polling timeout has expired
+ LOG.trace("{} Long polling timed out", logMsgPrefix);
+ } catch (CancellationException e) {
+ // The background operation thread was cancelled
+ LOG.trace("{} The background operation was cancelled", logMsgPrefix);
+ } catch (ExecutionException | InterruptedException e) {
+ // No op, we will deal with this exception later
+ LOG.error(logMsgPrefix + " Failed", e);
+ if (e.getCause() instanceof Exception && !aborted.get()) {
+ throw handleException((Exception)
e.getCause()).throwIfInstance(TException.class).defaultMetaException();
+ }
+ String errorMsg = e.getCause() != null ? e.getCause().getMessage() :
e.getMessage();
+ throw new MetaException(logMsgPrefix + " failed with " + errorMsg);
+ }
+
+ TableOpResp resp = new TableOpResp(id);
+ if (future.isDone()) {
+ resp.setFinished(true);
+ resp.setMessage(logMsgPrefix + (future.isCancelled() ? " Canceled" : "
Done"));
+ } else {
+ resp.setMessage(logMsgPrefix + " In-progress, state - " + state);
+ }
+ return resp;
+ }
+
+ private static TableOperationsHandler<?>
+ ofCache(String opId, boolean shouldCancel) throws TException,
IOException {
+ TableOperationsHandler<?> tableOp = null;
+ if (opId != null) {
+ tableOp = OPID_TO_HANDLER.get(opId);
+ if (tableOp == null && !shouldCancel) {
+ throw new MetaException("Couldn't find the drop operation by " + opId);
+ }
+ if (shouldCancel) {
+ if (tableOp != null) {
+ tableOp.cancelOperation();
+ } else {
+ tableOp = new TableOperationsHandler<>(opId) {
+ @Override
+ public TableOpResp toTableOpResp() throws TException {
+ TableOpResp resp = new TableOpResp(opId);
+ resp.setMessage("Drop operation has been canceled");
+ resp.setFinished(true);
+ return resp;
+ }
+ };
+ }
+ }
+ }
+ return tableOp;
+ }
+
+ public static <T extends TBase> TableOperationsHandler<T> offer(IHMSHandler
handler, T req)
+ throws TException, IOException {
+ if (req instanceof DropTableRequest dropTableReq) {
+ TableOperationsHandler<T> tableOp = (TableOperationsHandler<T>)
+ ofCache(dropTableReq.getId(), dropTableReq.isCancel());
+ if (tableOp == null) {
+ tableOp = new TableOperationsHandler<>(handler,
dropTableReq.isAsyncDrop(), req);
+ }
+ return tableOp;
+ }
+ throw new UnsupportedOperationException("Not yet implemented");
+ }
+
+ private void runTableOperation() throws TException, IOException {
+ try {
+ // currently this class only supports the drop table, we can the alter
table if possible in the future
+ if (request instanceof DropTableRequest dropReq) {
+ // drop any partitions
+ String catName = normalizeIdentifier(
+ dropReq.isSetCatalogName() ? dropReq.getCatalogName() :
getDefaultCatalog(handler.getConf()));
+ String name = normalizeIdentifier(dropReq.getTableName());
+ String dbname = normalizeIdentifier(dropReq.getDbName());
+ tableName = new TableName(catName, dbname, name);
+ logMsgPrefix = "Drop " + id + " on table " + tableName + ":";
Review Comment:
The `id` belongs to `TableOperationsHandler`, it could represent more than
drop table, how about using following msg for drop table:
```java
logMsgPrefix = "TableOperation [" + id + "] - Drop table " + tableName +
":";
```
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TableOperationsHandler.java:
##########
@@ -0,0 +1,380 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.util.concurrent.MoreExecutors;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.UUID;
+import java.util.concurrent.Callable;
+import java.util.concurrent.CancellationException;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.stream.Collectors;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hive.common.TableName;
+import org.apache.hadoop.hive.metastore.api.Database;
+import org.apache.hadoop.hive.metastore.api.DropTableRequest;
+import org.apache.hadoop.hive.metastore.api.GetTableRequest;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.NoSuchObjectException;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.hadoop.hive.metastore.api.TableOpResp;
+import org.apache.hadoop.hive.metastore.events.DropTableEvent;
+import org.apache.hadoop.hive.metastore.events.PreDropTableEvent;
+import org.apache.hadoop.hive.metastore.messaging.EventMessage;
+import org.apache.hadoop.hive.metastore.utils.MetaStoreUtils;
+import org.apache.hadoop.hive.metastore.utils.SecurityUtils;
+import org.apache.thrift.TBase;
+import org.apache.thrift.TException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.hadoop.hive.metastore.ExceptionHandler.handleException;
+import static
org.apache.hadoop.hive.metastore.HMSHandler.checkTableDataShouldBeDeleted;
+import static
org.apache.hadoop.hive.metastore.HMSHandler.isDbReplicationTarget;
+import static org.apache.hadoop.hive.metastore.HMSHandler.isMustPurge;
+import static
org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.getDefaultCatalog;
+import static
org.apache.hadoop.hive.metastore.utils.StringUtils.normalizeIdentifier;
+
+public class TableOperationsHandler<T extends TBase> {
+ private static final Logger LOG =
LoggerFactory.getLogger(TableOperationsHandler.class);
+ private static final Map<String, TableOperationsHandler<?>>
+ OPID_TO_HANDLER = new ConcurrentHashMap<>();
+ private static final ScheduledExecutorService OPID_CLEANER =
Executors.newScheduledThreadPool(1, r -> {
+ Thread thread = new Thread(r);
+ thread.setDaemon(true);
+ thread.setName("TableOperationsHandler-cleaner");
+ return thread;
+ });
+
+ private volatile StringBuffer state = new StringBuffer("Preparing context");
+ private String id;
+ private final IHMSHandler handler;
+ private final T request;
+ private final ExecutorService executor;
+ private final boolean async;
+ private Future<Void> future;
+ private Path tblPath;
+ private Table tbl;
+ private TableName tableName;
+ private volatile Object result;
+ private String logMsgPrefix;
+ private final AtomicBoolean aborted = new AtomicBoolean();
+
+ private TableOperationsHandler(String id) throws TException, IOException {
+ this(null, false, null);
+ this.id = id;
+ }
+
+ private TableOperationsHandler(IHMSHandler handler, boolean async, T request)
+ throws TException, IOException {
+ this.id = UUID.randomUUID().toString();
+ this.handler = handler;
+ this.request = request;
+ this.async = async;
+ OPID_TO_HANDLER.put(id, this);
+ if (async) {
+ this.executor = Executors.newFixedThreadPool(1, r -> {
+ Thread thread = new Thread(r);
+ thread.setDaemon(true);
+ thread.setName("TableOperationsHandler " + id);
+ return thread;
+ });
+ } else {
+ this.executor = MoreExecutors.newDirectExecutorService();
+ }
+ this.runTableOperation();
+ }
+
+ public void dropTable() throws TException {
+ DropTableRequest dropReq = (DropTableRequest) request;
+ DropTableResult dropResult = (DropTableResult) result;
+ boolean success = false;
+ List<Path> partPaths = null;
+ Map<String, String> transactionalListenerResponses =
Collections.emptyMap();
+ Database db = null;
+ boolean isReplicated = false;
+ RawStore ms = handler.getMS();
+ try {
+ ms.openTransaction();
+ String catName = tableName.getCat();
+ String dbname = tableName.getDb();
+ String name = tableName.getTable();
+ // HIVE-25282: Drop/Alter table in REMOTE db should fail
+ db = ms.getDatabase(catName, dbname);
+ if (MetaStoreUtils.isDatabaseRemote(db)) {
+ throw new MetaException("Drop table in REMOTE database " +
db.getName() + " is not allowed");
+ }
+ isReplicated = isDbReplicationTarget(db);
+
+ checkInterrupted();
+ // Check if table is part of a materialized view.
+ // If it is, it cannot be dropped.
+ List<String> isPartOfMV = ms.isPartOfMaterializedView(catName, dbname,
name);
+ if (!isPartOfMV.isEmpty()) {
+ throw new MetaException(String.format("Cannot drop table as it is used
in the following materialized" +
+ " views %s%n", isPartOfMV));
+ }
+
+ ((HMSHandler) handler).firePreEvent(new PreDropTableEvent(tbl,
dropReq.isDeleteData(), handler));
+
+ state = new StringBuffer();
+ // Drop the partitions and get a list of locations which need to be
deleted
+ if (dropReq.isDropPartitions()) {
+ checkInterrupted();
+ List<String> locations = ms.dropAllPartitionsAndGetLocations(tableName,
+ tblPath != null ? handler.getWh().getDnsPath(tblPath).toString() :
null, state);
+ partPaths =
locations.stream().map(Path::new).collect(Collectors.toList());
+ }
+ // Drop any constraints on the table
+ ms.dropConstraint(catName, dbname, name, null, true);
+
+ checkInterrupted();
+ state = new StringBuffer("Dropping table");
+ if (!ms.dropTable(catName, dbname, name)) {
+ throw new MetaException("Unable to drop table " + tableName);
+ } else {
+ state = new StringBuffer("Notifying transaction listeners");
+ if (!handler.getTransactionalListeners().isEmpty()) {
+ transactionalListenerResponses =
+
MetaStoreListenerNotifier.notifyEvent(handler.getTransactionalListeners(),
+ EventMessage.EventType.DROP_TABLE,
+ new DropTableEvent(tbl, true, dropReq.isDeleteData(),
handler, isReplicated),
+ dropReq.getEnvContext());
+ }
+ checkInterrupted();
+ success = ms.commitTransaction();
+ }
+ dropResult.fill(success, isMustPurge(dropReq.getEnvContext(), tbl),
+ ReplChangeManager.shouldEnableCm(db, tbl), partPaths);
+ } finally {
+ try {
+ if (!success) {
+ ms.rollbackTransaction();
+ }
+ if (!handler.getListeners().isEmpty()) {
+ MetaStoreListenerNotifier.notifyEvent(handler.getListeners(),
EventMessage.EventType.DROP_TABLE,
+ new DropTableEvent(tbl, success, dropReq.isDeleteData(),
handler, isReplicated), dropReq.getEnvContext(),
+ transactionalListenerResponses, ms);
+ }
+ } finally {
+ OPID_CLEANER.schedule(() -> OPID_TO_HANDLER.remove(id), 1,
TimeUnit.HOURS);
+ }
+ }
+ }
+
+ public TableOpResp toTableOpResp() throws TException {
+ if (future == null) {
+ throw new IllegalStateException(logMsgPrefix + " hasn't started yet");
+ }
+ try {
+ Object v = async ? future.get(100, TimeUnit.MILLISECONDS) : future.get();
+ } catch (TimeoutException e) {
+ // No Op, return to the caller since long polling timeout has expired
+ LOG.trace("{} Long polling timed out", logMsgPrefix);
+ } catch (CancellationException e) {
+ // The background operation thread was cancelled
+ LOG.trace("{} The background operation was cancelled", logMsgPrefix);
+ } catch (ExecutionException | InterruptedException e) {
+ // No op, we will deal with this exception later
+ LOG.error(logMsgPrefix + " Failed", e);
+ if (e.getCause() instanceof Exception && !aborted.get()) {
+ throw handleException((Exception)
e.getCause()).throwIfInstance(TException.class).defaultMetaException();
+ }
+ String errorMsg = e.getCause() != null ? e.getCause().getMessage() :
e.getMessage();
+ throw new MetaException(logMsgPrefix + " failed with " + errorMsg);
+ }
+
+ TableOpResp resp = new TableOpResp(id);
+ if (future.isDone()) {
+ resp.setFinished(true);
+ resp.setMessage(logMsgPrefix + (future.isCancelled() ? " Canceled" : "
Done"));
+ } else {
+ resp.setMessage(logMsgPrefix + " In-progress, state - " + state);
+ }
+ return resp;
+ }
+
+ private static TableOperationsHandler<?>
+ ofCache(String opId, boolean shouldCancel) throws TException,
IOException {
+ TableOperationsHandler<?> tableOp = null;
+ if (opId != null) {
+ tableOp = OPID_TO_HANDLER.get(opId);
+ if (tableOp == null && !shouldCancel) {
+ throw new MetaException("Couldn't find the drop operation by " + opId);
+ }
+ if (shouldCancel) {
+ if (tableOp != null) {
+ tableOp.cancelOperation();
+ } else {
+ tableOp = new TableOperationsHandler<>(opId) {
+ @Override
+ public TableOpResp toTableOpResp() throws TException {
+ TableOpResp resp = new TableOpResp(opId);
+ resp.setMessage("Drop operation has been canceled");
+ resp.setFinished(true);
+ return resp;
+ }
+ };
+ }
+ }
+ }
+ return tableOp;
+ }
+
+ public static <T extends TBase> TableOperationsHandler<T> offer(IHMSHandler
handler, T req)
+ throws TException, IOException {
+ if (req instanceof DropTableRequest dropTableReq) {
+ TableOperationsHandler<T> tableOp = (TableOperationsHandler<T>)
+ ofCache(dropTableReq.getId(), dropTableReq.isCancel());
+ if (tableOp == null) {
+ tableOp = new TableOperationsHandler<>(handler,
dropTableReq.isAsyncDrop(), req);
+ }
+ return tableOp;
+ }
+ throw new UnsupportedOperationException("Not yet implemented");
+ }
+
+ private void runTableOperation() throws TException, IOException {
+ try {
+ // currently this class only supports the drop table, we can the alter
table if possible in the future
+ if (request instanceof DropTableRequest dropReq) {
+ // drop any partitions
+ String catName = normalizeIdentifier(
+ dropReq.isSetCatalogName() ? dropReq.getCatalogName() :
getDefaultCatalog(handler.getConf()));
+ String name = normalizeIdentifier(dropReq.getTableName());
+ String dbname = normalizeIdentifier(dropReq.getDbName());
+ tableName = new TableName(catName, dbname, name);
+ logMsgPrefix = "Drop " + id + " on table " + tableName + ":";
+ GetTableRequest req = new GetTableRequest(dropReq.getDbName(),
dropReq.getTableName());
+ req.setCatName(catName);
+ tbl = handler.get_table_core(req);
+ if (tbl == null) {
+ throw new NoSuchObjectException(tableName + " doesn't exist");
+ }
+ if (tbl.getSd() == null) {
+ throw new MetaException("Table metadata is corrupted");
+ }
+ boolean tableDataShouldBeDeleted = checkTableDataShouldBeDeleted(tbl,
dropReq.isDeleteData());
+ if (tbl.getSd().getLocation() != null) {
+ tblPath = new Path(tbl.getSd().getLocation());
+ }
+ if (tableDataShouldBeDeleted && tblPath != null) {
+ if (!handler.getWh().isWritable(tblPath.getParent())) {
Review Comment:
Also need check if `tblPath` is writable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
