Aggarwal-Raghav commented on code in PR #6250:
URL: https://github.com/apache/hive/pull/6250#discussion_r2660608824
##########
standalone-metastore/metastore-tools/metastore-benchmarks/pom.xml:
##########
@@ -153,6 +148,9 @@
<transformer
implementation="org.apache.logging.log4j.maven.plugins.shade.transformer.Log4j2PluginCacheFileTransformer"/>
<transformer
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
<mainClass>org.apache.hadoop.hive.metastore.tools.BenchmarkTool</mainClass>
+ <manifestEntries>
+ <Multi-Release>true</Multi-Release>
Review Comment:
@dengzhhu653 , dnsjava-3.6.1 is a multi-release jar and after shading the
Multi-Release tag is getting dropped from `MANIFEST.MF`.
I was able to repro the ERROR message present on the JIRA .
<img width="1266" height="686" alt="Screenshot 2026-01-05 at 12 25 22 PM"
src="https://github.com/user-attachments/assets/3ab00cdb-9a16-4e9d-921e-5106838e3345";
/>
Before and after the fix,`META-INF/MANIFEST.MF` on hmsbench.jar
<img width="1329" height="241" alt="Screenshot 2026-01-05 at 12 50 10 PM"
src="https://github.com/user-attachments/assets/d2f1e39f-ec35-41ab-91f5-27ade0c51b55";
/>
I didn't explored if there is any other way to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
