deniskuzZ commented on code in PR #6256:
URL: https://github.com/apache/hive/pull/6256#discussion_r2660821642
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##########
@@ -238,7 +237,7 @@ private void validateCatalogConfigsDefined() {
* - Otherwise, the JSON is a list of SortFields; we convert it to Iceberg
* SortOrder JSON and keep it in DEFAULT_SORT_ORDER for Iceberg to use it.
*/
- private void setSortOrder(org.apache.hadoop.hive.metastore.api.Table
hmsTable, Schema schema,
+ protected void setSortOrder(org.apache.hadoop.hive.metastore.api.Table
hmsTable, Schema schema,
Review Comment:
why protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
