Indhumathi27 commented on code in PR #6202:
URL: https://github.com/apache/hive/pull/6202#discussion_r2668488039


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java:
##########
@@ -1300,9 +1300,17 @@ private static void 
runTopNKeyOptimization(OptimizeTezProcContext procCtx)
       return;
     }
 
+    // Restrict TopNKey matching to GROUP BY / JOIN ReduceSinks, except for 
PTF queries.
+    String reduceSinkOp = ReduceSinkOperator.getOperatorName() + "%";
+    String topNKeyRegexPattern = hasPTFReduceSink(procCtx) ? reduceSinkOp :
+            ".*(" + GroupByOperator.getOperatorName() + "|" +

Review Comment:
   yes. Some queries with Group by not matching current Regex pattern without 
the prefix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to