dengzhhu653 commented on PR #6265: URL: https://github.com/apache/hive/pull/6265#issuecomment-3753311535
> @dengzhhu653 , HiveConf changes in this PR are big +1 , I need some input on how to deal with the deprecated Metastore configs present in HiveConf. For example: > > ``` > METASTORE_AGGREGATE_STATS_CACHE_MAX_FULL > METASTORE_AGGREGATE_STATS_CACHE_CLEAN_UNTIL > ... > ``` > > I had filed [HIVE-29289](https://issues.apache.org/jira/browse/HIVE-29289) and the goal was to remove these configurations from HiveConf. Mostly these configs are used in test code. I was thinking of moving those tests in itests module to prevent cyclic depenedency **if** caused by adding metastore-comomon as dependency. Can you provide your thoughts on this? Not sure how it could introduce the cyclic depenedency, the hive-common has already contained the dependency on metastore-common, can you give an example? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
